GDK::TestURL#wait is failing due to hardcoded output
Overview
Flaky test
Failures:
1) GDK::TestURL#wait when URL is up behaves like a URL that's up calls #store_gitlab_commit_sha which writes into a file
Failure/Error: GDK::Output.notice("#{uri} is up (#{http_helper.last_response_reason}). Took #{duration} second(s).")
GDK::Output received :notice with unexpected arguments
expected: ("http://127.0.0.1:3000/users/sign_in is up (200 OK). Took 0.0 second(s).")
got: ("http://127.0.0.1:3000/users/sign_in is up (200 OK). Took 0.01 second(s).")
Shared Example Group: "a URL that's up" called from ./spec/lib/gdk/test_url_spec.rb:87
# ./lib/gdk/test_url.rb:35:in `wait'
# ./spec/lib/gdk/test_url_spec.rb:78:in `block (4 levels) in <top (required)>'
Proposal (optional)
Change test to use a pattern that accepts any value between Took
and second(s)
.