`gdk update` pulls outdated version of Gitaly when GITALY_SERVER_VERSION is updated
Overview
When doing a gdk update
where the GITALY_SERVER_VERSION
changes, GDK pulls in the old version which leads to slow test startup time because it would need to compile Gitaly every time.
This happens because gitaly-update
is run before gitlab-update
. So it fetches the Gitaly version in GITALY_SERVER_VERSION
in the Rails repo and then updates the Rails repo.
This slows down test setup because if the version does not match, it will delete the dir and clone again. What's worse is that it still clones the wrong version because it just clones from the Gitaly directory. This results in a warning like:
WARNING: Gitaly, version 14.4.0-rc43-6-gee4b20cc3 does not exactly match repository version bf9abd731ba2dab65e8c275c51d578d95dd3d506
Related Slack thread: https://gitlab.slack.com/archives/C02PF508L/p1635411884054700
Running another gdk update
fixes it since it will now fetch with the updated value in GITALY_SERVER_VERSION