Skip to content

gdk restart [<service>] runs `bin/spring stop`

Overview

From !1708 (comment 459979350):

Having this before stop is a bit confusing as it can stop spring when it really doesn't need to:

$ gdk restart runner
ℹ️  gdk stop: before hook -> cd gitlab && bin/spring stop || true
Spring is not running

We have the following default hooks in place:

gdk:
  stop_hooks:
    after: []
    before:
    - cd gitlab && bin/spring stop || true
  update_hooks:
    after: []
    before:
    - cd gitlab && bin/spring stop || true

Where any stop_hooks before and after are executed as part of a gdk restart [<service>] where it probably shouldn't be.

Proposal

Remove cd gitlab && bin/spring stop || true from stop_hooks.before.