Security Dashboard - pattern to denote null versus zero in line graphs
Graphs, like the security dashboard, need a consistent way to tell users of GitLab when an item is 0 versus no data available for that day/data point.
Consideration - at times there is math / addition involved - how would we detect one of the multiple elements contained a null not a 0?
I don't know
in graphs, for explicitly null vs 0, need to make sure backends are clear and correct about sending null versus 0
Dos and dont's
Links / references
Make sure these are completed before closing the issue, with a link to the relevant commit, if applicable.
- Read our contribution guidelines, especially the For GitLabbers section.
Create a Sketch file in your progress folder just for this pattern and make sure that:
- You have not created a duplicate of an existing pattern, symbol, layer style, or text style.
- You have used the proper method for creating the pattern depending on the complexity. Atoms and molecules are symbols, organisms are groups.
- Typography uses text styles. When applicable, colors use shared styles.
- Ask a UXer to review your Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue.
- QA of your Sketch file by the reviewer.
- Add your changes to the pattern library. When copying things over, watch out for duplicated symbols, layer styles, and text styles. Some of our recommended plugins can help you find and remove duplicates.
- QA of pattern library by the reviewer.
- Create an issue in the Design System to add the pattern documentation. Mark it as related to this issue.
- Add an agenda item to the next UX weekly call to inform everyone (if it's a new pattern, not yet used in the application).