Standardizing input tokens
Currently, our “input tokens”, like when selecting users or filters, have an inconsistent design.
|User token||Filter token|
Use similar design as filter tokens (this has the added benefit of removing another outlined element within GitLab):
(One or more images showing the UX pattern. They don’t have to be in GitLab.)
- When adding/inviting users to a project
Dos and dont's
(Use this table to add images and text describing what’s ok and not ok.)
||Add a hover state to the entire token (like filters). Clicking the token itself shouldn't do anything|
- Badges &979
Links / references
Make sure these are completed before closing the issue, with a link to the relevant commit, if applicable.
- Read our contribution guidelines, especially the For GitLabbers section.
Create a Sketch file in your progress folder just for this pattern and make sure that:
- You have not created a duplicate of an existing pattern, symbol, layer style, or text style.
- You have used the proper method for creating the pattern depending on the complexity. Atoms and molecules are symbols, organisms are groups.
- Typography uses text styles. When applicable, colors use shared styles.
- Ask a UXer to review your Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue.
- QA of your Sketch file by the reviewer.
- Add your changes to the pattern library. When copying things over, watch out for duplicated symbols, layer styles, and text styles. Some of our recommended plugins can help you find and remove duplicates.
- QA of pattern library by the reviewer.
- Create an issue in the Design System to add the pattern documentation. Mark it as related to this issue.
- Add an agenda item to the next UX weekly call to inform everyone (if it's a new pattern, not yet used in the application).