Design pattern library: Icon for collapsing and expanding sidebar
Currently, we use
collapse right to indicate collapsing and expanding of a sidebar. We use these icons in the main left navigation and in the issue/MR right sidebar.
However, when there are additional collapsible panes in a page, the usage of these icons becomes odd without a label for the button. For example, in the case of the file browser in the merge request page, the toggle button is outside the pane.
Replace the current set of icons with the following.
These 4 icons take into account if the sidebar is on the left or right (as indicated by the vertical line in the icons). Here are some mockups of how this will look in production.
|Left navigation||Right sidebar|
|MR File browser open||MR File browser closed|
Make sure these are completed before closing the issue, with a link to the relevant commit, if applicable.
- Read our contribution guidelines, especially the For GitLabbers section.
Create a Sketch file in your progress folder just for this pattern and make sure that:
- You have not created a duplicate of an existing pattern, symbol, layer style, or text style.
- You have used the proper method for creating the pattern depending on the complexity. Atoms and molecules are symbols, organisms are groups.
- Typography uses text styles. When applicable, colors use shared styles.
- Ask a UXer to review your Sketch file, linking them to your latest commit so they know where to find it. If they have the capacity, they should assign themselves to this issue.
- QA of your Sketch file by the reviewer.
- Add your changes to the pattern library. When copying things over, watch out for duplicated symbols, layer styles, and text styles. Some of our recommended plugins can help you find and remove duplicates.
- QA of pattern library by the reviewer.
- Create an issue in the Design System to add the pattern documentation. Mark it as related to this issue.
- Add an agenda item to the next UX weekly call to inform everyone (if it's a new pattern, not yet used in the application).