Document usage of buttons with both icon and text
Buttons should only contain an icon or a text, not both.
Our deprecated UX guide states this. This might not be true or a good thing perse. Let's revise that statement and document it in design.gitlab.com
If the situation makes sense for this kind of a solution it shouldn't be prevented. Icons have the great ability to make something recognizable in an instant, can carry multiple meanings, plus they often can solve space issues.
(What’s the solution? Why is it like that? What are the benefits?)
(One or more images showing the UX pattern. They don’t have to be in GitLab.)
(When do you use this pattern? And how?)
Dos and dont's
(Use this table to add images and text describing what’s ok and not ok.)
(List any related or similar solutions. If none, write: No related patterns)
Links / references
Make sure these are completed before closing the issue, with a link to the relevant commit, if applicable.
- Ensure that you have broken things down into atoms, molecules, and organisms.
- Check that you have not created a duplicate of an existing pattern.
- Ensure that you have used the proper method for creating the pattern depending on the complexity. Atoms and molecules are symbols, organisms are groups.
- Make sure that typography is using text styles. When applicable used shared styles for colors.
- QA check by another UXer
- Add changes to the pattern library
- Add a merge request that includes any new or updated guidelines to the Design System
- Add an agenda item to the next UX weekly call to inform everyone (if new pattern, not yet used in the application)