Inconsistent specification of stage: test in Auto DevOps
There's an inconsistent use of stage: test
in Auto DevOps jobs. The test
job states this, but others like codequality
and performance
infer it (test
is the default stage if stage is not specified).
I believe it would be clearer if all the test stage jobs stated stage: test
for consistency and clarity.
Has test stage:
test:
services:
- postgres:latest
variables:
POSTGRES_DB: test
stage: test
image: gliderlabs/herokuish:latest
script:
- setup_test_db
- cp -R . /tmp/app
- /bin/herokuish buildpack test
only:
- branches
Implied test stage:
codequality:
image: docker:latest
variables:
DOCKER_DRIVER: overlay2
allow_failure: true
services:
- docker:dind
script:
- setup_docker
- codeclimate
artifacts:
paths: [codeclimate.json]