Skip to content
Snippets Groups Projects

fix: read error from upload artifacts execution.

Merged Paul 🐻 requested to merge paulrbr/gitlab-runner:fix-artifact-upload-errors into master

What does this MR do?

Fixes a bug when an error occurs during the "artifacts upload" stage.

Why was this MR needed?

During a failure in the upload artifacts step of a build jobs were not failing. This is a problem.

I have tested my patch with a local build and it makes the job fail if an error occurs during artifact uploading execution:

FATAL: invalid argument                            
Job succeeded
FATAL: invalid argument                            
ERROR: Job failed: exit code 1

Are there points in the code the reviewer needs to double check?

Help would be appreciated to create a test case for failed uploads builds.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Fixes #2584 (closed)

Edited by Paul 🐻

Merge request reports

Pipeline #11008544 passed

Pipeline passed for fc554083 on paulrbr:fix-artifact-upload-errors

Merged by avatar (Apr 18, 2025 10:36pm UTC)

Loading

Pipeline #11028916 passed with warnings

Pipeline passed with warnings for 19ab26c3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading