Skip to content

Fix flaky test network.TestRequestsBackOff

Alessio Caiazza requested to merge (removed):fix/flaky_backoff_test into master

What does this MR do?

This patch fixes a flaky test in the network package.

Why was this MR needed?

In the last few days I worked on a couple of MRs and I had a lot of broken tests on TestRequestsBackOff.

Are there points in the code the reviewer needs to double check?

Backoff is provided by an external library so in this tests I removed the flaky time-based checks and just check for backoff attempts.

So we have to trust the backoff library about the timing and just check the CI backoff conditions.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

None

Merge request reports