Project 'gitlab-org/gitlab-ci-multi-runner' was moved to 'gitlab-org/gitlab-runner'. Please update any links and bookmarks that may still have the old path.

executor_docker_command.go

8 years ago

7249f3bb

Merge branch 'refactor-script-generation' into 'master' · 7249f3bb

Kamil Trzciński authored 8 years ago

Refactor script generation to make it fully on-demand

- Rename `ShellScript` to `ShellConfiguration` and remove all generated scripts
- Introduce `ShellScriptType` with different types of scripts
- Introduce `GetConfiguration` and `GenerateScript` for `Shell` interface
- Change `ShellScript` to `Shell` of `Executor`
- Remove `GenerateScript` from shells, instead provide a generic method with accepts `ShellScriptType`
- Introduce `executeShellScript` for `Build`, method which is responsible for generating and executing a shell script

@tmaczukin What do you think?


See merge request !189

7249f3bb

History

Merge branch 'refactor-script-generation' into 'master'

Kamil Trzciński authored 8 years ago

Refactor script generation to make it fully on-demand

- Rename `ShellScript` to `ShellConfiguration` and remove all generated scripts
- Introduce `ShellScriptType` with different types of scripts
- Introduce `GetConfiguration` and `GenerateScript` for `Shell` interface
- Change `ShellScript` to `Shell` of `Executor`
- Remove `GenerateScript` from shells, instead provide a generic method with accepts `ShellScriptType`
- Introduce `executeShellScript` for `Build`, method which is responsible for generating and executing a shell script

@tmaczukin What do you think?


See merge request !189

Code owners

Assign users and groups as approvers for specific file changes. Learn more.