• Yorick Peterse's avatar
    Clean up ActiveRecord code in TodoService · 38b8ae64
    Yorick Peterse authored
    This refactors the TodoService class according to our code reuse
    guidelines. The resulting code is a wee bit more verbose, but it allows
    us to decouple the column names from the input, resulting in fewer
    changes being necessary when we change the schema.
    
    One particular noteworthy line in TodoService is the following:
    
        todos_ids = todos.update_state(state)
    
    Technically this is a violation of the guidelines, because
    `update_state` is a class method, which services are not supposed to use
    (safe for a few allowed ones). I decided to keep this, since there is no
    alternative. `update_state` doesn't produce a relation so it doesn't
    belong in a Finder, and we can't move it to another Service either. As
    such I opted to just use the method directly.
    
    Cases like this may happen more frequently, at which point we should
    update our documentation with some sort of recommendation. For now, I
    want to refrain from doing so until we have a few more examples.
    38b8ae64
Name
Last commit
Last update
..
admin Loading commit data...
autocomplete Loading commit data...
concerns Loading commit data...
README.md Loading commit data...
access_requests_finder.rb Loading commit data...
awarded_emoji_finder.rb Loading commit data...
branches_finder.rb Loading commit data...
clusters_finder.rb Loading commit data...
contributed_projects_finder.rb Loading commit data...
environments_finder.rb Loading commit data...
events_finder.rb Loading commit data...
fork_projects_finder.rb Loading commit data...
group_descendants_finder.rb Loading commit data...
group_finder.rb Loading commit data...
group_labels_finder.rb Loading commit data...
group_members_finder.rb Loading commit data...
group_projects_finder.rb Loading commit data...
groups_finder.rb Loading commit data...
issuable_finder.rb Loading commit data...
issues_finder.rb Loading commit data...
joined_groups_finder.rb Loading commit data...
labels_finder.rb Loading commit data...
license_template_finder.rb Loading commit data...
members_finder.rb Loading commit data...
merge_request_target_project_finder.rb Loading commit data...
merge_requests_finder.rb Loading commit data...
milestones_finder.rb Loading commit data...
notes_finder.rb Loading commit data...
pending_todos_finder.rb Loading commit data...
personal_access_tokens_finder.rb Loading commit data...
personal_projects_finder.rb Loading commit data...
pipeline_schedules_finder.rb Loading commit data...
pipelines_finder.rb Loading commit data...
projects_finder.rb Loading commit data...
runner_jobs_finder.rb Loading commit data...
snippets_finder.rb Loading commit data...
tags_finder.rb Loading commit data...
template_finder.rb Loading commit data...
todos_finder.rb Loading commit data...
union_finder.rb Loading commit data...
user_finder.rb Loading commit data...
user_recent_events_finder.rb Loading commit data...
users_finder.rb Loading commit data...
users_with_pending_todos_finder.rb Loading commit data...