Apply code review suggestions

Apply code review suggestions
99 jobs for mh/collapsible-boards in 77 minutes and 43 seconds (queued for 17 seconds)
Status Job ID Name Coverage
  Build
manual #239750351
gitlab-org allowed to fail manual
review-docs-deploy-manual
 
  Prepare
passed #239750353
gitlab-org
compile-assets pull-cache

00:06:05

passed #239750358
gitlab-org
retrieve-tests-metadata

00:00:23

passed #239750354
gitlab-org
setup-test-env

00:04:31

 
  Test
passed #239750522
docker gitlab-org
build-qa-image

00:05:00

passed #239750410
allowed to fail
code_quality

00:09:19

passed #239750524
gitlab-org
danger-review

00:03:02

passed #239750511
gitlab-org
db:check-schema-pg

00:03:18

passed #239750508
gitlab-org
db:migrate:reset-pg

00:02:31

passed #239750517
gitlab-org
db:rollback-pg

00:02:36

passed #239750414
allowed to fail
dependency_scanning

00:08:47

passed #239750359
gitlab-org
docs lint

00:02:34

passed #239750505
gitlab-org
downtime_check

00:01:46

passed #240633759
gitlab-org
ee_compat_check

00:04:27

passed #239750360
gitlab-org docker
gitlab:assets:compile pull-cache

00:15:52

passed #239750519
gitlab-org
gitlab:setup-pg

00:04:39

passed #239750525
gitlab-org
gitlab_git_test

00:00:29

passed #239750368
gitlab-org
jest

00:15:45

passed #239750366
gitlab-org
karma

00:10:43

54.63%
passed #239750528
gitlab-org
lint-ci-gitlab

00:01:08

passed #239750403
gitlab-org
memory-static

00:03:00

passed #239750513
gitlab-org
migration:path-pg

00:04:11

passed #239750526
gitlab-org
no_ee_check

00:01:20

passed #239750394
gitlab-org
qa-frontend-node:10

00:13:56

passed #239750389
gitlab-org
qa-frontend-node:8

00:17:20

passed #239750399
gitlab-org allowed to fail
qa-frontend-node:latest

00:14:10

passed #239750375
gitlab-org
qa:internal

00:03:36

passed #239750387
gitlab-org
qa:selectors

00:02:51

passed #239750523
allowed to fail manual
review-build-cng

00:26:29

passed #239750459
gitlab-org
rspec integration pg 1/6

00:17:29

passed #239750460
gitlab-org
rspec integration pg 2/6

00:18:25

passed #239750461
gitlab-org
rspec integration pg 3/6

00:16:38

passed #239750469
gitlab-org
rspec integration pg 4/6

00:17:47

passed #239750471
gitlab-org
rspec integration pg 5/6

00:16:55

passed #239750472
gitlab-org
rspec integration pg 6/6

00:17:09

passed #239750473
gitlab-org
rspec system pg 1/24

00:11:40

passed #239750486
gitlab-org
rspec system pg 10/24

00:12:31

passed #239750487
gitlab-org
rspec system pg 11/24

00:11:12

passed #239750488
gitlab-org
rspec system pg 12/24

00:13:14

passed #239750490
gitlab-org
rspec system pg 13/24

00:11:54

passed #239750491
gitlab-org
rspec system pg 14/24

00:13:28

passed #239750492
gitlab-org
rspec system pg 15/24

00:14:14

passed #239750493
gitlab-org
rspec system pg 16/24

00:11:54

passed #239750494
gitlab-org
rspec system pg 17/24

00:12:10

passed #239750495
gitlab-org
rspec system pg 18/24

00:12:00

passed #239750496
gitlab-org
rspec system pg 19/24

00:11:43

passed #239750476
gitlab-org
rspec system pg 2/24

00:11:11

passed #239750497
gitlab-org
rspec system pg 20/24

00:13:06

passed #239750499
gitlab-org
rspec system pg 21/24

00:14:37

passed #239750500
gitlab-org
rspec system pg 22/24

00:14:23

passed #239750501
gitlab-org
rspec system pg 23/24

00:11:29

passed #239750502
gitlab-org
rspec system pg 24/24

00:13:00

passed #239750478
gitlab-org
rspec system pg 3/24

00:11:14

passed #239750480
gitlab-org
rspec system pg 4/24

00:12:00

passed #239750481
gitlab-org
rspec system pg 5/24

00:12:42

passed #239750482
gitlab-org
rspec system pg 6/24

00:14:19

passed #239750483
gitlab-org
rspec system pg 7/24

00:12:16

passed #239750484
gitlab-org
rspec system pg 8/24

00:11:01

passed #239750485
gitlab-org
rspec system pg 9/24

00:12:56

passed #239750415
gitlab-org
rspec unit pg 1/20

00:12:41

passed #239750431
gitlab-org
rspec unit pg 10/20

00:15:22

passed #239750437
gitlab-org
rspec unit pg 11/20

00:19:45

passed #239750438
gitlab-org
rspec unit pg 12/20

00:15:29

passed #239750441
gitlab-org
rspec unit pg 13/20

00:17:03

passed #239750443
gitlab-org
rspec unit pg 14/20

00:17:22

passed #239750445
gitlab-org
rspec unit pg 15/20

00:16:56

passed #239750446
gitlab-org
rspec unit pg 16/20

00:16:29

passed #239750447
gitlab-org
rspec unit pg 17/20

00:16:48

passed #239750450
gitlab-org
rspec unit pg 18/20

00:17:32

passed #239750455
gitlab-org
rspec unit pg 19/20

00:13:32

passed #239750417
gitlab-org
rspec unit pg 2/20

00:14:04

passed #239750457
gitlab-org
rspec unit pg 20/20

00:16:08

passed #239750419
gitlab-org
rspec unit pg 3/20

00:14:32

passed #239750421
gitlab-org
rspec unit pg 4/20

00:14:54

passed #239750423
gitlab-org
rspec unit pg 5/20

00:14:26

passed #239750424
gitlab-org
rspec unit pg 6/20

00:16:20

passed #239750425
gitlab-org
rspec unit pg 7/20

00:16:22

passed #239750426
gitlab-org
rspec unit pg 8/20

00:16:38

passed #239750428
gitlab-org
rspec unit pg 9/20

00:17:11

passed #239750503
gitlab-org
rspec-fast-spec-helper

00:03:04

passed #239750413
allowed to fail
sast

00:19:08

passed #239750504
gitlab-org
static-analysis

00:13:57

failed #239960580
gitlab-org
ee_compat_check

00:02:46

failed #239750507
gitlab-org
ee_compat_check

00:03:11

 
  Review
manual #239750531
allowed to fail manual
package-and-qa
failed #239750532
gitlab-org allowed to fail
review-deploy

00:17:30

manual #239750533
gitlab-org allowed to fail manual
review-stop
 
  Qa
passed #239750542
docker gitlab-org allowed to fail
review-performance

00:02:47

manual #239750535
docker gitlab-org allowed to fail manual
review-qa-all 1/5
manual #239750538
docker gitlab-org allowed to fail manual
review-qa-all 2/5
manual #239750539
docker gitlab-org allowed to fail manual
review-qa-all 3/5
manual #239750540
docker gitlab-org allowed to fail manual
review-qa-all 4/5
manual #239750541
docker gitlab-org allowed to fail manual
review-qa-all 5/5
passed #239750534
docker gitlab-org allowed to fail
review-qa-smoke

00:04:25

 
  Post Test
passed #239750545
gitlab-org
coverage

00:03:20

95.74%
failed #239750546
gitlab-org allowed to fail
flaky-examples-check

00:01:52

passed #239750544
gitlab-org
jsdoc

00:01:41

passed #239750543
gitlab-org
lint:javascript:report

00:00:47

 
  Post Cleanup
manual #239750549
gitlab-org allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
flaky-examples-check Post Test
    "first_flaky_at": "2019-06-25 16:03:12 +0000",
"last_flaky_at": "2019-06-25 16:03:12 +0000",
"last_flaky_job": "https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/239750446"
}
}
Running after script...
$ date
Wed Jun 26 17:25:48 UTC 2019
ERROR: Job failed: exit code 1
failed
review-deploy Review
sys	0m0.338s
.............................................................
The Review App at https://gitlab-review-mh-collaps-7g46h0.ce.gitlab-review.app isn't ready after 5 minutes of polling...
Running after script...
$ date
Wed Jun 26 17:19:19 UTC 2019
Uploading artifacts...
review_app_url.txt: found 1 matching files
Uploading artifacts to coordinator... ok id=239750532 responseStatus=201 Created token=hnabsiVr
ERROR: Job failed: exit code 1