Utilize :key to minimize extra rerenders

The diff notes automatically focus on mount, and when using the index
(as opposed to line_code) for the v-bind:key, the comment form gets
unnecessarily remounted, and therefore refocused.
144 jobs for 51606-expanding-a-diff-while-having-an-open-comment-form-will-always-scroll-down-to-the-comment in 60 minutes and 1 second (queued for 6 seconds)
Status Job ID Name Coverage
  Build
manual #135880998
gitlab-org allowed to fail manual
review-docs-deploy-manual
 
  Prepare
passed #135881002
gitlab-org docker
build-qa-image

00:04:34

passed #135881000
gitlab-org
compile-assets

00:08:05

passed #135880999
gitlab-org
retrieve-tests-metadata

00:00:22

passed #135881001
gitlab-org
setup-test-env

00:05:17

 
  Test
passed #135881131
allowed to fail
code_quality

00:08:59

passed #135881004
danger-review

00:02:08

passed #135881116
gitlab-org
db:check-schema-pg

00:02:35

passed #135881115
gitlab-org
db:migrate:reset-mysql

00:05:17

passed #135881114
gitlab-org
db:migrate:reset-pg

00:03:07

passed #135881123
gitlab-org
db:rollback-mysql

00:04:44

passed #135881121
gitlab-org
db:rollback-pg

00:03:04

passed #135881133
allowed to fail
dependency_scanning

00:05:42

passed #135881111
gitlab-org
docs lint

00:01:46

passed #135881112
gitlab-org
downtime_check

00:01:46

passed #135881113
gitlab-org
ee_compat_check

00:02:48

passed #135881128
gitlab-org-delivery high-cpu
gitlab:assets:compile

00:14:07

passed #135881126
gitlab-org
gitlab:setup-mysql

00:05:38

passed #135881124
gitlab-org
gitlab:setup-pg

00:06:49

passed #135881140
gitlab-org
gitlab_git_test

00:00:30

passed #135881130
gitlab-org
jest

00:12:28

passed #135881129
gitlab-org
karma

00:12:22

58.29%
passed #135881120
gitlab-org
migration:path-mysql

00:12:51

passed #135881118
gitlab-org
migration:path-pg

00:11:43

passed #135881141
gitlab-org
no_ee_check

00:00:21

manual #135881003
allowed to fail manual
package-and-qa
passed #135881138
qa-frontend-node:10

00:10:11

passed #135881136
qa-frontend-node:6

00:12:59

passed #135881137
qa-frontend-node:8

00:07:53

passed #135881139
allowed to fail
qa-frontend-node:latest

00:10:33

passed #135881134
gitlab-org
qa:internal

00:02:45

passed #135881135
gitlab-org
qa:selectors

00:02:50

passed #135881142
gitlab-org allowed to fail
review-deploy

00:31:37

manual #135881144
gitlab-org docker allowed to fail manual
review-qa-all
failed #135891750
gitlab-org docker allowed to fail
review-qa-smoke

00:14:38

passed #135881145
gitlab-org allowed to fail manual
review-stop

00:00:44

passed #135881058
gitlab-org
rspec-mysql 1/50

00:11:20

passed #135881068
gitlab-org
rspec-mysql 10/50

00:12:26

passed #135881070
gitlab-org
rspec-mysql 11/50

00:11:22

passed #135881071
gitlab-org
rspec-mysql 12/50

00:14:59

passed #135881072
gitlab-org
rspec-mysql 13/50

00:12:03

passed #135881073
gitlab-org
rspec-mysql 14/50

00:13:16

passed #135881074
gitlab-org
rspec-mysql 15/50

00:11:20

passed #135881075
gitlab-org
rspec-mysql 16/50

00:12:24

passed #135881076
gitlab-org
rspec-mysql 17/50

00:13:36

passed #135881077
gitlab-org
rspec-mysql 18/50

00:13:54

passed #135881078
gitlab-org
rspec-mysql 19/50

00:16:49

passed #135881059
gitlab-org
rspec-mysql 2/50

00:06:08

passed #135881079
gitlab-org
rspec-mysql 20/50

00:13:24

passed #135881080
gitlab-org
rspec-mysql 21/50

00:13:34

passed #135881081
gitlab-org
rspec-mysql 22/50

00:15:09

passed #135881082
gitlab-org
rspec-mysql 23/50

00:15:40

passed #135881083
gitlab-org
rspec-mysql 24/50

00:15:03

passed #135881084
gitlab-org
rspec-mysql 25/50

00:13:26

passed #135881085
gitlab-org
rspec-mysql 26/50

00:17:06

passed #135881086
gitlab-org
rspec-mysql 27/50

00:19:21

passed #135881087
gitlab-org
rspec-mysql 28/50

00:13:29

passed #135881088
gitlab-org
rspec-mysql 29/50

00:16:41

passed #135881060
gitlab-org
rspec-mysql 3/50

00:12:08

passed #135881089
gitlab-org
rspec-mysql 30/50

00:17:09

passed #135881090
gitlab-org
rspec-mysql 31/50

00:15:02

passed #135881091
gitlab-org
rspec-mysql 32/50

00:14:20

passed #135881092
gitlab-org
rspec-mysql 33/50

00:15:45

passed #135881093
gitlab-org
rspec-mysql 34/50

00:14:45

passed #135881094
gitlab-org
rspec-mysql 35/50

00:15:48

passed #135881095
gitlab-org
rspec-mysql 36/50

00:14:56

passed #135881096
gitlab-org
rspec-mysql 37/50

00:13:16

passed #135881097
gitlab-org
rspec-mysql 38/50

00:14:19

passed #135881098
gitlab-org
rspec-mysql 39/50

00:14:56

passed #135881061
gitlab-org
rspec-mysql 4/50

00:11:20

passed #135881099
gitlab-org
rspec-mysql 40/50

00:13:49

passed #135881100
gitlab-org
rspec-mysql 41/50

00:15:54

passed #135881101
gitlab-org
rspec-mysql 42/50

00:14:16

passed #135881102
gitlab-org
rspec-mysql 43/50

00:17:51

passed #135881103
gitlab-org
rspec-mysql 44/50

00:18:35

passed #135881104
gitlab-org
rspec-mysql 45/50

00:13:50

passed #135881105
gitlab-org
rspec-mysql 46/50

00:14:40

passed #135881106
gitlab-org
rspec-mysql 47/50

00:14:47

passed #135881107
gitlab-org
rspec-mysql 48/50

00:13:49

passed #135881108
gitlab-org
rspec-mysql 49/50

00:13:23

passed #135881062
gitlab-org
rspec-mysql 5/50

00:12:48

passed #135881109
gitlab-org
rspec-mysql 50/50

00:12:52

passed #135881063
gitlab-org
rspec-mysql 6/50

00:10:41

passed #135881064
gitlab-org
rspec-mysql 7/50

00:11:59

passed #135881065
gitlab-org
rspec-mysql 8/50

00:13:18

passed #135881066
gitlab-org
rspec-mysql 9/50

00:09:41

passed #135881005
gitlab-org
rspec-pg 1/50

00:12:17

passed #135881015
gitlab-org
rspec-pg 10/50

00:13:30

passed #135881016
gitlab-org
rspec-pg 11/50

00:09:56

passed #135881017
gitlab-org
rspec-pg 12/50

00:15:15

passed #135881018
gitlab-org
rspec-pg 13/50

00:10:57

passed #135881019
gitlab-org
rspec-pg 14/50

00:11:57

passed #135881020
gitlab-org
rspec-pg 15/50

00:11:01

passed #135881021
gitlab-org
rspec-pg 16/50

00:12:32

passed #135881022
gitlab-org
rspec-pg 17/50

00:12:17

passed #135881024
gitlab-org
rspec-pg 18/50

00:13:24

passed #135881025
gitlab-org
rspec-pg 19/50

00:13:53

passed #135881006
gitlab-org
rspec-pg 2/50

00:07:41

passed #135881026
gitlab-org
rspec-pg 20/50

00:11:39

passed #135881027
gitlab-org
rspec-pg 21/50

00:12:08

passed #135881028
gitlab-org
rspec-pg 22/50

00:13:42

passed #135881029
gitlab-org
rspec-pg 23/50

00:14:18

passed #135881031
gitlab-org
rspec-pg 24/50

00:13:50

passed #135881032
gitlab-org
rspec-pg 25/50

00:11:36

passed #135881033
gitlab-org
rspec-pg 26/50

00:14:30

passed #135881034
gitlab-org
rspec-pg 27/50

00:13:40

passed #135881035
gitlab-org
rspec-pg 28/50

00:12:59

passed #135881036
gitlab-org
rspec-pg 29/50

00:12:43

passed #135881007
gitlab-org
rspec-pg 3/50

00:10:39

passed #135881037
gitlab-org
rspec-pg 30/50

00:13:22

passed #135881038
gitlab-org
rspec-pg 31/50

00:13:52

passed #135881039
gitlab-org
rspec-pg 32/50

00:14:00

passed #135881040
gitlab-org
rspec-pg 33/50

00:14:34

passed #135881041
gitlab-org
rspec-pg 34/50

00:12:47

passed #135881042
gitlab-org
rspec-pg 35/50

00:10:22

passed #135881043
gitlab-org
rspec-pg 36/50

00:12:45

passed #135881044
gitlab-org
rspec-pg 37/50

00:12:45

passed #135881045
gitlab-org
rspec-pg 38/50

00:12:32

passed #135881046
gitlab-org
rspec-pg 39/50

00:14:42

passed #135881008
gitlab-org
rspec-pg 4/50

00:10:48

passed #135881047
gitlab-org
rspec-pg 40/50

00:12:55

passed #135881048
gitlab-org
rspec-pg 41/50

00:14:43

passed #135881049
gitlab-org
rspec-pg 42/50

00:11:52

passed #135881050
gitlab-org
rspec-pg 43/50

00:13:15

passed #135881051
gitlab-org
rspec-pg 44/50

00:14:07

passed #135881052
gitlab-org
rspec-pg 45/50

00:13:37

passed #135881053
gitlab-org
rspec-pg 46/50

00:13:18

passed #135881054
gitlab-org
rspec-pg 47/50

00:12:38

passed #135881055
gitlab-org
rspec-pg 48/50

00:12:32

passed #135881056
gitlab-org
rspec-pg 49/50

00:12:28

passed #135881009
gitlab-org
rspec-pg 5/50

00:12:18

passed #135881057
gitlab-org
rspec-pg 50/50

00:13:33

passed #135881010
gitlab-org
rspec-pg 6/50

00:10:38

passed #135881011
gitlab-org
rspec-pg 7/50

00:13:00

passed #135881012
gitlab-org
rspec-pg 8/50

00:13:16

passed #135881014
gitlab-org
rspec-pg 9/50

00:09:04

passed #135881132
allowed to fail
sast

00:04:05

passed #135881110
gitlab-org
static-analysis

00:09:47

failed #135881143
gitlab-org docker allowed to fail
review-qa-smoke

00:46:05

failed #135889425
docker gitlab-org allowed to fail
review-qa-smoke

00:14:25

 
  Post Test
passed #135881147
gitlab-org
coverage

00:04:45

100.0%
passed #135881146
gitlab-org allowed to fail
flaky-examples-check

00:01:33

passed #135881148
gitlab-org
lint:javascript:report

00:00:50

 
  Post Cleanup
manual #135881149
gitlab-org allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
review-qa-smoke Test
Randomized with seed 11635

Running after script...
$ date
Tue Dec 18 02:50:57 UTC 2018
Uploading artifacts...
./qa/gitlab-qa-run-*: found 24 matching files
Uploading artifacts to coordinator... ok
id=135891750 responseStatus=201 Created token=967fsUzN
ERROR: Job failed: exit code 1