Skip to content

UI: Allow a project variable to be set to an empty value

Rémy Coutable requested to merge lnovy/gitlab-ce-empty-variables into master

Originally opened at !6044 (closed) by @lnovy.


What does this MR do?

This changes project variables UI forms to allow the variable's value to be set to an empty value.

Are there points in the code the reviewer needs to double check?

I've also robustified some other scenarios in the test spec besides adding a new one which tests the empty value.

Why was this MR needed?

Empty valued environment variables are perfectly valid and useful. Setting the value empty can also server as a poor-man's way to "unset" the variable if it was defined somewhere lower in the order of precedence as documented at [http://docs.gitlab.com/ce/ci/variables/README.html]

What are the relevant issue numbers?

None.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

Merge request reports