Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Add auto-cancel for pending pipelines on branch, if they are not HEAD
-
Review changes -
-
Download -
Patches
-
Plain diff
Merged
Maxim Rydkin requested to merge innerwhisper/gitlab-ce:8998_skip_pending_commits_if_not_head into master
What does this MR do?
Decrease entropy in Gitlab universe
First iteration for #8998 (closed)
-
Adds option "Auto-cancel pending pipelines" in "CI/CD Pipelines" project settings tab: when checkbox checked, all pending non-HEAD pipelines will be canceled by system, automatizing scenario:
1. "User creates pipeline for branch" / "User pushes commit to gitlab" 2. User goes to pipelines index page and cancel unnecessary (only pending) pipelines.
-
Adds
target: '_blank'
to doc links in "CI/CD Pipelines" project settings tab -
Refactor
spec/services/ci/create_pipeline_service_spec.rb
, extractingexecute_service
method
UI:
- Pipeline list:
-
Tooltip on canceled status badge
-
- MR widget/commit widget:
-
Pipeline #12345678 was auto-canceled.. etc
-
Hovering over the words auto-canceled
will bring the same tooltips
-
- Pipeline page:
-
Tooltip on canceled status badge
-
- Pipeline graph job node:
-
has improved tooltip with auto-canceled
(not anything else)
-
- Mini pipeline graph stage and job status icons
-
has improved tooltip with auto-canceled
(not anything else)
-
- Job list
-
Tooltip on canceled status badge
-
- Job list in pipeline view
-
Tooltip on canceled status badge
-
- Job view
-
Tooltip on canceled status badge
-
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Many reasons are discussed here #8998 (closed)
Screenshots (if relevant)
Option in CI/CD Pipelines Project settings tab:
Pipeline list:
Pipeline page:
Job list:
Job view:
Job list in pipeline view:
Setting:
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Compare and
Show latest version
- version 72f8fe64a6
- version 71e28fc7b1
- version 705a4aee36
- version 69beedfc8d
- version 68b85ddc84
- version 67503f8822
- version 66503f8822
- version 651ac44911
- version 641ac44911
- version 63cdfa17c4
- version 621bed2c87
- version 6138c324b9
- version 60057c0d7a
- version 5906b4ea24
- version 5806b4ea24
- version 57f7014cd5
- version 56f7014cd5
- version 55e258e6f1
- version 54e258e6f1
- version 536bf1780a
- version 526bf1780a
- version 5134eea295
- version 502d4fd769
- version 4925756618
- version 48756d727a
- version 473ae3f280
- version 46336c9763
- version 45601da3a0
- version 4477e36d35
- version 43c12c1c57
- version 42b2ead4c0
- version 41b2d5488a
- version 40ff1ff53c
- version 3995139971
- version 38278f2152
- version 370b089e86
- version 36238bba96
- version 35a42dcabd
- version 345d275427
- version 33fcc3b002
- version 324a544551
- version 31365db60d
- version 3069ca7e6b
- version 29a35d09ab
- version 287cf1f9a6
- version 27a94c054e
- version 26bc4bafcd
- version 254f95fe8d
- version 24ff5a7e39
- version 23976baf5a
- version 221d552ce1
- version 21ae4dcbe9
- version 20e45a103b
- version 19d46888d3
- version 18ba96f9cb
- version 17778f3e98
- version 16743a7dd6
- version 15e49a62c8
- version 149774ed73
- version 13de02b23f
- version 12c275ce79
- version 11ba4cf678
- version 10afeb0280
- version 926c5b783
- version 84363d390
- version 701cdbb2f
- version 65b322ef6
- version 55141f184
- version 4e94bca72
- version 37ded70b8
- version 285a29bb0
- version 1d3598011
- master (base)
- latest version38796f5648 commits,
- version 72f8fe64a647 commits,
- version 71e28fc7b146 commits,
- version 705a4aee3645 commits,
- version 69beedfc8d44 commits,
- version 68b85ddc8443 commits,
- version 67503f882242 commits,
- version 66503f882242 commits,
- version 651ac4491141 commits,
- version 641ac4491141 commits,
- version 63cdfa17c440 commits,
- version 621bed2c8739 commits,
- version 6138c324b938 commits,
- version 60057c0d7a37 commits,
- version 5906b4ea2435 commits,
- version 5806b4ea2435 commits,
- version 57f7014cd532 commits,
- version 56f7014cd532 commits,
- version 55e258e6f131 commits,
- version 54e258e6f131 commits,
- version 536bf1780a30 commits,
- version 526bf1780a30 commits,
- version 5134eea29527 commits,
- version 502d4fd76926 commits,
- version 492575661824 commits,
- version 48756d727a23 commits,
- version 473ae3f28022 commits,
- version 46336c976321 commits,
- version 45601da3a020 commits,
- version 4477e36d3519 commits,
- version 43c12c1c5719 commits,
- version 42b2ead4c018 commits,
- version 41b2d5488a17 commits,
- version 40ff1ff53c16 commits,
- version 399513997115 commits,
- version 38278f215214 commits,
- version 370b089e8613 commits,
- version 36238bba9612 commits,
- version 35a42dcabd11 commits,
- version 345d27542710 commits,
- version 33fcc3b0029 commits,
- version 324a5445518 commits,
- version 31365db60d7 commits,
- version 3069ca7e6b6 commits,
- version 29a35d09ab5 commits,
- version 287cf1f9a64 commits,
- version 27a94c054e3 commits,
- version 26bc4bafcd2 commits,
- version 254f95fe8d1 commit,
- version 24ff5a7e391 commit,
- version 23976baf5a1 commit,
- version 221d552ce11 commit,
- version 21ae4dcbe96 commits,
- version 20e45a103b5 commits,
- version 19d46888d34 commits,
- version 18ba96f9cb3 commits,
- version 17778f3e982 commits,
- version 16743a7dd61 commit,
- version 15e49a62c81 commit,
- version 149774ed731 commit,
- version 13de02b23f1 commit,
- version 12c275ce791 commit,
- version 11ba4cf6782 commits,
- version 10afeb02801 commit,
- version 926c5b7831 commit,
- version 84363d3901 commit,
- version 701cdbb2f1 commit,
- version 65b322ef61 commit,
- version 55141f1841 commit,
- version 4e94bca721 commit,
- version 37ded70b81 commit,
- version 285a29bb02 commits,
- version 1d35980111 commit,
3 files
+ 16
− 3
Compare changes
- Side-by-side
- Inline
Files
3+ 1
− 1
@@ -123,6 +123,6 @@ def detailed_status?(status)
Loading