Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Use iids as filter parameter
What does this MR do?
iids
is used as parameter for filtering milestones by iid
instead of iid
so that we're consistent across the API.
Why was this MR needed?
API consistency
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Fixes #27532 (closed)
Merge request reports
Activity
assigned to @jarka
assigned to @vsizov
added 263 commits
-
66d369c7...edb8ed36 - 262 commits from branch
gitlab-org:master
- fdff9f81 - Use iids as filter parameter
-
66d369c7...edb8ed36 - 262 commits from branch
@jarka please pick another reviewer, Valery is out this week
assigned to @rdavila
- Resolved by Jarka Košanová
@jarka thanks for working on it, I just left a small comment, other than that it LGTM!
assigned to @jarka
Thanks for the feedback @rdavila . I added specs for case no milestone is found and
iid
is invalidassigned to @rdavila
added 1154 commits
-
e5174439...90040620 - 1153 commits from branch
gitlab-org:master
- 0f3de3ce - Use iids as filter parameter
-
e5174439...90040620 - 1153 commits from branch
Please register or sign in to reply