Skip to content
Snippets Groups Projects

Use iids as filter parameter

Merged Jarka Košanová requested to merge jarka/gitlab-ce:27532_api_changes into master

What does this MR do?

iids is used as parameter for filtering milestones by iid instead of iid so that we're consistent across the API.

Why was this MR needed?

API consistency

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes #27532 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @jarka thanks for working on it, I just left a small comment, other than that it LGTM!

  • assigned to @jarka

  • added 1 commit

    • e5174439 - Use iids as filter parameter

    Compare with previous version

  • Thanks for the feedback @rdavila . I added specs for case no milestone is found and iid is invalid

  • Jarka Košanová added 1154 commits

    added 1154 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading