Skip to content
Snippets Groups Projects

Fixed flexbox and wrap issues

Merged Luke Bennett requested to merge correct-issue-filter-dropdown-user-avatar-stretch into master
All threads resolved!

What does this MR do?

@cperessini found this issue.

Screen_Shot_2017-01-24_at_14.19.22

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2017-01-24_at_14.19.09

extreme example:

Screen_Shot_2017-01-24_at_14.18.57

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Can you fix failed builds and include changelog?

  • Author Contributor

    Didn't think we were adding changelogs for regression fixes?

  • Luke Bennett resolved all discussions

    resolved all discussions

  • Luke Bennett added 31 commits

    added 31 commits

    Compare with previous version

  • Ok, we can label this as a regression

  • Clement Ho added ~17876 label

    added ~17876 label

  • Author Contributor
  • Luke Bennett added 44 commits

    added 44 commits

    Compare with previous version

  • mentioned in issue #26846 (closed)

  • Author Contributor

    @ClemMakesApps is right this many dropdowns unless they've been explicitly set to something else.

    Screen_Shot_2017-01-26_at_11.24.17Screen_Shot_2017-01-26_at_11.24.27

    I'm going to set max-width to 280px but keep everything else the same as it was before by setting min-width to 240px. :)

    Edited by Luke Bennett
  • Luke Bennett resolved all discussions

    resolved all discussions

  • Luke Bennett added 120 commits

    added 120 commits

    Compare with previous version

  • Luke Bennett added 26 commits

    added 26 commits

    Compare with previous version

  • Looks great @lbennett! Apologies for the long name everybody :smile:

  • mentioned in commit f3ca739d

  • @cperessini I'm still not convinced that 280px is the right width but we can take a look at dev tomorrow and see. Thanks for working on this @lbennett :100:

  • mentioned in issue #27400 (closed)

  • Picked into 8-16-stable, will be in 8.16.3

  • Robert Speicher removed ~149423 label

    removed ~149423 label

  • Please register or sign in to reply
    Loading