Use #parts instead of #part to read all the parts of the Message.
What does this MR do?
Fix an incorrect usage of a method to read the parts of an email message.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
It was adding an extra empty Mime section which was giving issues in some mail clients. You can see more information related to this here: https://productforums.google.com/forum/#!topic/gmail/aVoLmVuhV_c
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- Changelog entry added
- Documentation created/updated
- API support added
- Added for this feature/bug
- All builds are passing
- Conform by the merge request performance guides
- Conform by the style guides
Branch has no merge conflicts with
master(if it does - rebase it please)
- Squashed related commits together
What are the relevant issue numbers?
Closes #26463 (closed)
@rdavila started a discussion on the diff
5 5 def self.delivering_email(message) 6 6 # Remove HTML part if HTML emails are disabled. 7 7 unless current_application_settings.html_emails_enabled 8 message.part.delete_if do |part| 9 part.content_type.try(:start_with?, 'text/html')
#partwas also returning the new added Mime section which was having an empty
content type, that is no longer the case when using
#partswhich only returns the two parts of the message: plain text and HTML.
resolved all discussionsToggle commit list
mergedToggle commit list
8-15-stable, will be in
removed ~149423 labelToggle commit list