Skip to content

Make CI badge hitboxes better match container

What does this MR do?

Makes the Pipeline graph badge hitboxes accurately match their containers. Currently, there's an issue where the badge highlights, as though, it's clickable, but clicking it does nothing:

before

This is due to the <a> and <button> elements being padded into the parent elements. So, the parent would react to a cursor, but the cursor wouldn't be on the <a>/<button> yet.

before-hitbox

Are there points in the code the reviewer needs to double check?

Maybe the tests? I kept the style changes as minimal as possible.

Why was this MR needed?

I was annoyed every time I clicked on a badge that I was clearly on (it highlighted), but nothing happened. If I found it irritating, perhaps someone else did too.

Screenshots (if relevant)

How it behaves in the PR: finished

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #25547 (closed)

Merge request reports