Go to a project order
What does this MR do?
Changes "Go to a project" order: now it's sorted by user's starred projects first then ordered by project name "ASC"
Are there points in the code the reviewer needs to double check?
No
Why was this MR needed?
Related to the issue #18786 (closed)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Closes #18786 (closed)
Merge request reports
Activity
- Resolved by 🙈 jacopo beschi 🙉
Thanks for your contributions @jacopo-beschi
@rymai can you take a look?
Reassigned to @rymai
@rymai After checking the MR changes I've seen that now the order is by default by created_at desc. Before the parameter was handled in the helpers.rb and now is passed as default value. You still want me to check for that in the filter_projects and if the defaults are passed add an ordering by user starred first? Also In case you want me to do that there is a smart way to check from grape if the default params are passed?
@jacopo-beschi Thanks but I have some concerns about the default ordering, I think we could simply start with ordering projects by last activity, the changes would be simpler, see https://gitlab.com/gitlab-org/gitlab-ce/issues/18786#note_19958492.
assigned to @jacopo-beschi
added 1174 commits
-
3717bd96...9a3c53fd - 1173 commits from branch
gitlab-org:master
- 24d01bce - Go to a project order
-
3717bd96...9a3c53fd - 1173 commits from branch
- Resolved by 🙈 jacopo beschi 🙉
Thanks @jacopo-beschi, much simpler! :)
@iamphill Could you please have a look?
- Resolved by 🙈 jacopo beschi 🙉
assigned to @alfredo1
mentioned in issue #18786 (closed)
- Resolved by 🙈 jacopo beschi 🙉
changed milestone to %8.16
Tested and LGTM! thanks @jacopo-beschi!
mentioned in commit 2ed90c45