Skip to content
Snippets Groups Projects

Go to a project order

All threads resolved!

What does this MR do?

Changes "Go to a project" order: now it's sorted by user's starred projects first then ordered by project name "ASC"

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

Related to the issue #18786 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #18786 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Added 1 commit:

    Compare with previous version

  • Clement Ho Added ~164274 label

    Added ~164274 label

  • Thanks for your contributions @jacopo-beschi :tada:

    @rymai can you take a look?

  • Reassigned to @rymai

  • 🙈 jacopo beschi 🙉 resolved all discussions

    resolved all discussions

  • @rymai After checking the MR changes I've seen that now the order is by default by created_at desc. Before the parameter was handled in the helpers.rb and now is passed as default value. You still want me to check for that in the filter_projects and if the defaults are passed add an ordering by user starred first? Also In case you want me to do that there is a smart way to check from grape if the default params are passed?

  • @jacopo-beschi Thanks but I have some concerns about the default ordering, I think we could simply start with ordering projects by last activity, the changes would be simpler, see https://gitlab.com/gitlab-org/gitlab-ce/issues/18786#note_19958492.

  • added 1174 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Thanks @jacopo-beschi, much simpler! :)

    @iamphill Could you please have a look?

  • Rémy Coutable added ~127616 label

    added ~127616 label

  • LGTM :thumbsup: Just use the $dropdown variable instead of $(dropdown) :smiley:

  • added 1 commit

    Compare with previous version

  • Just noticed this JS error after closing the dropdown:

    Screen_Shot_2016-12-15_at_11.59.17

  • Thank you for the notice, I haven't seen that error my bad. I'll fix it

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • 🙈 jacopo beschi 🙉 resolved all discussions

    resolved all discussions

  • assigned to @alfredo1

  • Alfredo Sumaran
  • Alfredo Sumaran changed milestone to %8.16

    changed milestone to %8.16

  • Tested and LGTM! thanks @jacopo-beschi!

  • Alfredo Sumaran mentioned in commit 2ed90c45

    mentioned in commit 2ed90c45

  • 🙈 jacopo beschi 🙉 resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading