Skip to content
Snippets Groups Projects

Promote project labels to group labels

Worked live with @DouweM / @smcgivern for the initial spike.

What does this MR do?

Gives the ability for the Group Admin to promote Project Labels to Group Labels.

Are there points in the code the reviewer needs to double check?

  • Icon for the promote action is needed in the Project's Labels list
  • Labels from all the issues before promotion should be updated to point to the new one
  • All the labels from Projects inside the Group with the same name should be merged into the new Group Label
  • Label promotion requires ability to edit all the projects inside the group, Group Admin permissions is required
  • Are the label priorities in each project are the same as before merge
  • optional: How to resolve description during project merges. My solution for now will be - use the one which had the promote button pressed.

Does this MR meet the acceptance criteria?

Screenshot

Feature preview

What are the relevant issue numbers?

Closes #24021 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reassigned to @DouweM

  • @ritave Why was the mode for app/helpers/labels_helper.rb changed?

  • @ritave Can you update the task list in the issue description?

  • Olaf Tomalka Marked the task CHANGELOG entry added as completed

    Marked the task CHANGELOG entry added as completed

  • Marked the task Documentation created/updated as completed

  • Olaf Tomalka Marked the task API support added as completed

    Marked the task API support added as completed

  • Olaf Tomalka Marked the task Added for this feature/bug as completed

    Marked the task Added for this feature/bug as completed

  • Olaf Tomalka Marked the task All builds are passing as completed

    Marked the task All builds are passing as completed

  • Douwe Maan
  • Olaf Tomalka Marked the task Conform by the style guides as completed

    Marked the task Conform by the style guides as completed

  • Author Contributor

    @DouweM Mode change was an issue with Virtual Machine and Samba workflow, I'll fix it on next commit.

  • Olaf Tomalka Marked the task Labels from all the issues before promotion should be updated to point to the new one as completed

    Marked the task Labels from all the issues before promotion should be updated to point to the new one as completed

  • Olaf Tomalka Marked the task All the labels from Projects inside the Group with the same name should be merged into the new Group Label as completed

    Marked the task All the labels from Projects inside the Group with the same name should be merged into the new Group Label as completed

  • Olaf Tomalka Marked the task Label promotion requires ability to edit all the projects inside the group, Group Admin permissions is required as completed

    Marked the task Label promotion requires ability to edit all the projects inside the group, Group Admin permissions is required as completed

  • Olaf Tomalka Marked the task Are the label priorities in each project are the same as before merge as completed

    Marked the task Are the label priorities in each project are the same as before merge as completed

  • Olaf Tomalka Marked the task optional: How to resolve description during project merges. My solution for now will be - use the one which had the promote button pressed. as completed

    Marked the task optional: How to resolve description during project merges. My solution for now will be - use the one which had the promote button pressed. as completed

  • Author Contributor

    @DouweM / @smcgivern It looks like labels can also have an Issue Board list which is not fixed after the promotion. I'll update the lists and add tests.

  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • @DouweM / @smcgivern It looks like labels can also have an Issue Board list which is not fixed after the promotion. I'll update the lists and add tests.

    @ritave Good catch! Anything that has label_id is suspect :)

  • @ritave Do you think it makes sense to mention this in documentation?

  • @ritave We don't need to spend too much time on UX, but what do you think of the http://fontawesome.io/icon/level-up/ icon?

    @dimitrieh Maybe you can think of a more appropriate icon? :)

    Edited by Douwe Maan
  • Author Contributor

    @DouweM I don't think it needs documentation, it's automatic and should be discovered when needed and doesn't change much of the previous workflow of all the projects (no gotchas). Icons looks good, I'm assuming it's already in Gitlab's Font Awesome.

  • @DouweM I quite like the fontawesome icon :) let's try with that one first?

  • Olaf Tomalka Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Olaf Tomalka Marked the task Icon for the promote action is needed in the Project's Labels list as completed

    Marked the task Icon for the promote action is needed in the Project's Labels list as completed

  • Olaf Tomalka Marked the task Conform by the merge request performance guides as completed

    Marked the task Conform by the merge request performance guides as completed

  • Olaf Tomalka Marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

    Marked the task Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Marked the task Squashed related commits together as completed

  • Author Contributor

    @DouweM ping, done, squashed and tests running.

  • Olaf Tomalka Resolved all discussions

    Resolved all discussions

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading