Promote project labels to group labels
Worked live with @DouweM / @smcgivern for the initial spike.
What does this MR do?
Gives the ability for the Group Admin to promote Project Labels to Group Labels.
Are there points in the code the reviewer needs to double check?
-
Icon for the promote action is needed in the Project's Labels list -
Labels from all the issues before promotion should be updated to point to the new one -
All the labels from Projects inside the Group with the same name should be merged into the new Group Label -
Label promotion requires ability to edit all the projects inside the group, Group Admin permissions is required -
Are the label priorities in each project are the same as before merge -
optional: How to resolve description during project merges. My solution for now will be - use the one which had the promote button pressed.
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
Screenshot
What are the relevant issue numbers?
Closes #24021 (closed)
Merge request reports
Activity
Reassigned to @smcgivern
Added 1 commit:
- 981f2531 - [WIP] Added working implementation of label promotion.
Added 1 commit:
- f2afa73f - [WIP] Make rubocop happy in promote_service[_spec].rb
@DouweM / @smcgivern This feature only needs an icon and a rebase, otherwise I believe it's good to go, and is review ready :)
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
Reassigned to @DouweM
- Resolved by Olaf Tomalka
@ritave Why was the mode for
app/helpers/labels_helper.rb
changed?@ritave Can you update the task list in the issue description?
Marked the task CHANGELOG entry added as completed
Marked the task Documentation created/updated as completed
- Resolved by Olaf Tomalka
Marked the task Conform by the style guides as completed
@DouweM Mode change was an issue with Virtual Machine and Samba workflow, I'll fix it on next commit.
@DouweM / @smcgivern It looks like labels can also have an Issue Board list which is not fixed after the promotion. I'll update the lists and add tests.
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
- Resolved by Olaf Tomalka
@DouweM / @smcgivern It looks like labels can also have an Issue Board list which is not fixed after the promotion. I'll update the lists and add tests.
@ritave Good catch! Anything that has
label_id
is suspect :)@ritave Do you think it makes sense to mention this in documentation?
@ritave We don't need to spend too much time on UX, but what do you think of the http://fontawesome.io/icon/level-up/ icon?
@dimitrieh Maybe you can think of a more appropriate icon? :)
Edited by Douwe Maan@DouweM I don't think it needs documentation, it's automatic and should be discovered when needed and doesn't change much of the previous workflow of all the projects (no gotchas). Icons looks good, I'm assuming it's already in Gitlab's Font Awesome.
@DouweM I quite like the fontawesome icon :) let's try with that one first?
Marked the task Conform by the merge request performance guides as completed
Marked the task Squashed related commits together as completed
@DouweM ping, done, squashed and tests running.