Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Don't execute git hooks if you create branch as part of other change
-
Review changes -
-
Download -
Patches
-
Plain diff
What does this MR do?
Currently, our procedure for adding a commit requires us to execute CreateBranchService
before file creation.
It's OK, but also we do execute git hooks
(the PostReceive
sidekiq job) as part of this process.
However, this hook is execute before the file is actually committed, so the ref is updated.
Secondly, we do execute a git hooks
after committing file and updating ref.
This results in duplicate PostReceive
jobs, where the first one is completely invalid.
This change makes the branch creation, something that is intermediate step of bigger process (file creation or update, commit cherry pick or revert) to not execute git hooks.
Why was this MR needed?
Adds a to CreateBranchService
an option to disable hooks execution.
Does this MR meet the acceptance criteria?
-
CHANGELOG entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Merge request reports
Compare and
Show latest version
- version 78eb242fc8
- version 77406dfd6e
- version 768f3aa6ac
- version 75d475fa09
- version 7405f4e48a
- version 739bb4cd75
- version 724587c78a
- version 71a6394540
- version 7023dd8d56
- version 6973eab4b1
- version 68ccc73c45
- version 67e3c36850
- version 66358501df
- version 65a4b97b2c
- version 64593228ff
- version 63a30f278b
- version 62ae86a1b9
- version 610b3b56b3
- version 609244c81b
- version 59e01c692a
- version 5899ac0935
- version 5705d742a0
- version 56c1a75c3c
- version 55104bac3d
- version 5499b55697
- version 531ad9c29c
- version 529df47620
- version 516fb10a90
- version 50d03c605b
- version 49dc4b3dd0
- version 4826af4b5a
- version 47eddb0636
- version 46e5acebd9
- version 45c0dfa0c6
- version 44e0df1b5f
- version 433e01385b
- version 423e01385b
- version 41bb9d3059
- version 40e7599eb0
- version 399c6563f6
- version 3807b9b80a
- version 378384d0d8
- version 363fa3fcd7
- version 35691f1c49
- version 34cf677378
- version 33ae5b935b
- version 3256e0dcab
- version 31e36088dd
- version 304b3c18ce
- version 29fff3c526
- version 285ba468ef
- version 275ecd0c81
- version 266ae1a73c
- version 2565806ec6
- version 24444da6f4
- version 23a52dc7ce
- version 22bc1d6cb5
- version 21e866985b
- version 206cd2256c
- version 19b82f415f
- version 189b63addb
- version 1713936f38
- version 16d4d138ee
- version 153e69c716
- version 14cd22fdd5
- version 1339d83f72
- version 12a68a6201
- version 11d8fe2fac
- version 105b0e631c
- version 930bcc3de
- version 8eddee5fe
- version 730d7b5c3
- version 692a43826
- version 50b5a2eef
- version 43128641f
- version 392aa4028
- version 24b20cb5d
- version 1a431ca0f
- master (base)
- latest version54fca95190 commits,
- version 78eb242fc889 commits,
- version 77406dfd6e88 commits,
- version 768f3aa6ac87 commits,
- version 75d475fa0986 commits,
- version 7405f4e48a85 commits,
- version 739bb4cd7584 commits,
- version 724587c78a82 commits,
- version 71a639454081 commits,
- version 7023dd8d5681 commits,
- version 6973eab4b181 commits,
- version 68ccc73c4580 commits,
- version 67e3c3685079 commits,
- version 66358501df78 commits,
- version 65a4b97b2c77 commits,
- version 64593228ff76 commits,
- version 63a30f278b74 commits,
- version 62ae86a1b973 commits,
- version 610b3b56b371 commits,
- version 609244c81b70 commits,
- version 59e01c692a69 commits,
- version 5899ac093568 commits,
- version 5705d742a067 commits,
- version 56c1a75c3c65 commits,
- version 55104bac3d63 commits,
- version 5499b5569762 commits,
- version 531ad9c29c63 commits,
- version 529df4762062 commits,
- version 516fb10a9061 commits,
- version 50d03c605b59 commits,
- version 49dc4b3dd057 commits,
- version 4826af4b5a56 commits,
- version 47eddb063656 commits,
- version 46e5acebd955 commits,
- version 45c0dfa0c654 commits,
- version 44e0df1b5f53 commits,
- version 433e01385b52 commits,
- version 423e01385b52 commits,
- version 41bb9d305951 commits,
- version 40e7599eb048 commits,
- version 399c6563f646 commits,
- version 3807b9b80a45 commits,
- version 378384d0d844 commits,
- version 363fa3fcd742 commits,
- version 35691f1c4941 commits,
- version 34cf67737840 commits,
- version 33ae5b935b38 commits,
- version 3256e0dcab36 commits,
- version 31e36088dd35 commits,
- version 304b3c18ce34 commits,
- version 29fff3c52631 commits,
- version 285ba468ef30 commits,
- version 275ecd0c8129 commits,
- version 266ae1a73c28 commits,
- version 2565806ec627 commits,
- version 24444da6f426 commits,
- version 23a52dc7ce25 commits,
- version 22bc1d6cb524 commits,
- version 21e866985b22 commits,
- version 206cd2256c21 commits,
- version 19b82f415f19 commits,
- version 189b63addb19 commits,
- version 1713936f3819 commits,
- version 16d4d138ee18 commits,
- version 153e69c71617 commits,
- version 14cd22fdd516 commits,
- version 1339d83f7215 commits,
- version 12a68a620114 commits,
- version 11d8fe2fac13 commits,
- version 105b0e631c13 commits,
- version 930bcc3de11 commits,
- version 8eddee5fe10 commits,
- version 730d7b5c39 commits,
- version 692a438267 commits,
- version 50b5a2eef6 commits,
- version 43128641f5 commits,
- version 392aa40283 commits,
- version 24b20cb5d2 commits,
- version 1a431ca0f1 commit,
Compare changes
- Side-by-side
- Inline
Files
285Loading