Skip to content

refactor(email): use setter method instead AR callbacks

Semyon Pupkov requested to merge artofhuman/gitlab-ce:remove-callback into master

What does this MR do?

This MR removes AR before_validation callback in favor setter.

Are there points in the code the reviewer needs to double check?

No

Why was this MR needed?

Because setters it`s good practice to normalize model attributes instead AR callbacks. Because new object should be valid right after initialization. If it MR interested I can try to find other places where we can use setters.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Merge request reports