Memoize GitLab::Shell's secret token
What does this MR do?
API::Helpers#secret_token was reading the secret file on every invocation. This MR reads the file in the
gitlab_shell_secret_token.rb initializer and saves it as a class variable at
Are there points in the code the reviewer needs to double check?
- I'm not sure if the use of
cattr_accessoris the best approach, or if should be moved into the
class << selfblock?
API::Helpers#secret_tokenbe removed in favor of using
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- CHANGELOG entry added
- Documentation created/updated
- API support added
- Added for this feature/bug
- All builds are passing
- Conform by the merge request performance guides
- Conform by the style guides
Branch has no merge conflicts with
master(if you do - rebase it please)
- Squashed related commits together