Skip to content

Resolve Merge conflicts in editor

Alfredo Sumaran requested to merge merge-conflicts-editor-2 into master

What does this MR do?

This is the second iteration of https://gitlab.com/gitlab-org/gitlab-ce/issues/20344 which now allows to resolve conflicts manually providing an editor to the user.

Are there points in the code the reviewer needs to double check?

  • Previous implementation has been refactored almost from the ground up.
  • Also some components like parallel-conflict-lines has been optimized to work well with PhantomJS.
  • The app and files required files are loaded only when needed. merge_conflicts_bundle.js is only loaded in /<group>/<project>/merge_requests/<Id>/conflicts only

Why was this MR needed?

Some MRs were unable to be solved interactively in the UI, with this MR we let the user to manually fix complex merge request conflicts.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20344, https://gitlab.com/gitlab-org/gitlab-ce/issues/3567.

Merge request reports