Skip to content
Snippets Groups Projects

Move pushes_since_gc to Redis

Merged Yorick Peterse requested to merge pushes-since-gc-redis into master
All threads resolved!

What does this MR do?

This moves tracking of the pushes since the last Git GC to Redis to reduce DB load.

Are there points in the code the reviewer needs to double check?

Styling mostly.

Why was this MR needed?

Updating this column can lead to a lot of writes which in turn puts a lot of load on table vacuuming. For example, in the last hour alone we had 5067 UPDATEs for this column (per InfluxDB):

> select count(increment_pushes_since_gc_call_count) from sidekiq_transactions where time > now() - 1h;
name: sidekiq_transactions
--------------------------
time                    count
1473780996567714622     5067

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/22125

cc @stanhu @pcarranza

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Speicher Canceled the automatic merge

    Canceled the automatic merge

  • Yorick Peterse Added 1 commit:

    Added 1 commit:

    • 4e87c023 - Move pushes_since_gc to Redis
  • Robert Speicher Resolved all discussions

    Resolved all discussions

  • Reassigned to @rspeicher

  • Robert Speicher Status changed to merged

    Status changed to merged

  • Robert Speicher Mentioned in commit 4f6ad25b

    Mentioned in commit 4f6ad25b

  • Please register or sign in to reply
    Loading