Skip to content
Snippets Groups Projects

Don't parse Rinku returned value to DocFragment when didn't change original html string.

Merged Paco Guzman requested to merge 18593-avoid-parse_html-when-rinku-didnt-do-anything into master
2 unresolved threads

What does this MR do?

Avoid parsing html string to doc fragment when Rinku.auto_link does not modify the html string

Why was this MR needed?

To try to reduce time on AutolinkFilter calls

What are the relevant issue numbers?

#18593 (closed)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
15 15 expect(filter(act).to_html).to eq exp
16 16 end
17 17
18 context 'when does nothing' do
  • Yorick Peterse Milestone changed to %8.10

    Milestone changed to %8.10

  • Yorick Peterse Added ~159098 ~18308 labels

    Added ~159098 ~18308 labels

  • Reassigned to @pacoguzman

  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 66b3be08 - Don't parse Rinku returned value to DocFragment when didn't change original html string.
  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 1798ebc1 - Don't parse Rinku returned value to DocFragment when didn't change original html string.
  • 64 64 - Collapse large diffs by default (!4990)
    65 65 - Fix mentioned users list on diff notes
    66 66 - Fix creation of deployment on build that is retried, redeployed or rollback
    67 - Don't parse Rinku returned value to DocFragment when didn't change original html string.
  • Reassigned to @pacoguzman

  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • d67df64a - Don't parse Rinku returned value to DocFragment when didn't change original html string.
  • Paco Guzman Added 1 commit:

    Added 1 commit:

    • 0c2da7f7 - Don't parse Rinku returned value to DocFragment when it didn't change the original html string.
  • Yorick Peterse Marked the task All builds are passing as completed

    Marked the task All builds are passing as completed

  • Yorick Peterse Status changed to merged

    Status changed to merged

  • Yorick Peterse mentioned in commit f6c6e91d

    mentioned in commit f6c6e91d

  • Paco Guzman Added ~149423 label

    Added ~149423 label

  • Picked into 8-10-stable, will go into 8.10.0-rc11.

  • Rémy Coutable Removed ~149423 label

    Removed ~149423 label

  • Yorick Peterse mentioned in commit dfbc30ee

    mentioned in commit dfbc30ee

  • Please register or sign in to reply
    Loading