Skip to content
Snippets Groups Projects

Dropdown loading time preformance fix

Merged Tiago Botelho requested to merge tiagonbotelho/gitlab-ce:dropdown-load-fix into master

What does this MR do?

Optimizes the performance of the dropdown load time by just sending the required data to load the dropdown instead of the full object

This MR aims to fix #17474 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @tiagonbotelho Some specs are failing, please fix :)

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • 1b111b83 - changes the usage of simpleprojectdetails to already implemented basicprojectsde…
  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • 94d9e168 - changes the project_title_spec accordingly
  • Tiago Botelho Added 2 commits:

    Added 2 commits:

    • 58c76f4b - fixes missing field on basicprojectdetails
    • b0b374b8 - removes gemfile.lock dotfiles
  • Reassigned to @dbalexandre

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • d85dde19 - adds test to check json fields on simple request and changes the url request format
  • Reassigned to @dbalexandre

  • @tiagonbotelho LGTM :thumbsup: Just a minor comment.

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • a5cf953d - moves let variable to it statement by using a local variable
  • Reassigned to @DouweM

  • thanks @dbalexandre already fixed it ;) assigning it to a endboss now \cc @DouweM

  • @tiagonbotelho Please remove the [WIP] prefix from the title to allow it to be merged.

  • Tiago Botelho Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • 3ee328dc - changes string to symbol in param
  • Reassigned to @DouweM

  • Tiago Botelho Added 432 commits:

    Added 432 commits:

    • 3ee328dc...850bb6db - 410 commits from branch gitlab-org:master
    • e1c5eb48 - implements filter_params
    • a8cf4e13 - adds basic functionality to the new endpoint of the api
    • 331f026a - gets the new object through /simple endpoint and renders on the dropdown
    • 98406810 - removes debugging print
    • 6715ea7d - adds entry to changelog
    • f5d92d12 - changes the usage of simpleprojectdetails to already implemented basicprojectsde…
    • 8a4f2d4d - changes the project_title_spec accordingly
    • 87d4d76d - fixes missing field on basicprojectdetails
    • f0c437ca - removes gemfile.lock dotfiles
    • c4dc0f52 - adds test to check json fields on simple request and changes the url request format
    • a4678edd - moves let variable to it statement by using a local variable
    • be3409ab - changes string to symbol in param
    • ded67d3b - implements filter_params
    • 2179c405 - adds basic functionality to the new endpoint of the api
    • 10c5eea5 - gets the new object through /simple endpoint and renders on the dropdown
    • 2a161e7a - removes debugging print
    • 8d9e649c - changes the usage of simpleprojectdetails to already implemented basicprojectsde…
    • 9018f46b - changes the project_title_spec accordingly
    • 84346da0 - fixes missing field on basicprojectdetails
    • 9102ad1f - removes gemfile.lock dotfiles
    • da137ec3 - adds test to check json fields on simple request and changes the url request format
    • b4a919ab - Merge branch 'dropdown-load-fix' of gitlab.com:tiagonbotelho/gitlab-ce into dropdown-load-fix
  • Tiago Botelho Added 2 commits:

    Added 2 commits:

    • 563b303b - removes basicprojectwithaccess and replaces it with basicprojectdetails
    • 3e44aac0 - fixes test according to four-phase test pattern
  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • 770d2831 - fixes test for simplified version of project
  • Tiago Botelho Added 1 commit:

    Added 1 commit:

    • 9fa8cf67 - removes redundant filter_branches file
  • Reassigned to @DouweM

  • @tiagonbotelho What's the added lib/api/.projects.rb.swn file?

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

  • Reassigned to @DouweM

  • Tiago Botelho Added 1 commit:

    Added 1 commit:

  • Douwe Maan Status changed to merged

    Status changed to merged

  • Douwe Maan mentioned in commit b8f67b4d

    mentioned in commit b8f67b4d

  • @DouweM I know it is a moot point since this is already merged, but shouldn't we wait to clean up a MR like this before merging it? Unless I'm missing something, this MR adds 40 commits and 100KB of git history for a 24-line change. I don't know whether GitLab has a policy on this but I would be interested in knowing.

  • @euphoria In this instance, I had missed the fact that this MR contained so many commits. If I had seen it, I would've asked @tiagonbotelho to squash them into at most a handful.

  • @tiagonbotelho Could you please leave the merge request template when filling out the merge request? In that case, we would not miss that so easy since there is a dedicated task for squashing related commits together.

  • @euphoria @razer6 It was my fault since at the time I did not know about squashing commits. Every MR that I submit now has the template to help both the reviewer and me. So sorry for the trouble

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading