Skip to content
Snippets Groups Projects

Fixed 'use shortcuts' button on docs

What does this MR do?

Exposes 'onToggleHelp() to window object through showHelp() so a help panel can be toggled globally using showHelp().

Are there points in the code the reviewer needs to double check?

Is this the best implementation? I actually think this is tidier than doing something like onclick="new Shortcuts().onToggleHelp" or $.trigger 'keydown', char: '?' but let me know.

Why was this MR needed?

Docs UX

What are the relevant issue numbers?

Closes #19157 (closed).

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reassigned to @lbennett

  • Luke Bennett Added 75 commits:

    Added 75 commits:

    • 73d43c5c...84113d7e - 74 commits from branch master
    • 8cdee2ba - Exposed 'onToggleHelp() to window object so showHelp() can be a global function'
  • Reassigned to @fatihacet

  • 9 9
    10 10 onToggleHelp: (e) =>
    11 11 e.preventDefault()
    12 @toggleHelp(@enabledHelp)
    12 Shortcuts.toggleHelp(@enabledHelp)
    13 13
    14 toggleMarkdownPreview: (e) =>
    14 toggleMarkdownPreview: (e) ->
  • Fatih Acet Status changed to merged

    Status changed to merged

  • Fatih Acet mentioned in commit 48843c0d

    mentioned in commit 48843c0d

  • Fatih Acet Milestone changed to %8.10

    Milestone changed to %8.10

  • Since this is a regression, can it be merged into next patch release of 8.9.x?

  • Robert Speicher Milestone changed to %8.9

    Milestone changed to %8.9

  • Robert Speicher Added ~149423 label

    Added ~149423 label

  • @blackst0ne I agree, this is a regression, so we'll get it in a patch.

  • mentioned in issue #18343 (closed)

  • mentioned in issue #19488 (closed)

  • Robert Speicher Removed ~149423 label

    Removed ~149423 label

  • Picked into 8-9-stable, will be in 8.9.5.

  • Fatih Acet mentioned in commit c090535a

    mentioned in commit c090535a

  • Please register or sign in to reply
    Loading