Skip to content
Snippets Groups Projects

Split Cropper.js from the main JavaScript manifest.

Merged Connor Shea requested to merge cs-cropper into master

What does this MR do?

Splits Cropper.js from the main JavaScript file.

Are there points in the code the reviewer needs to double check?

That the avatar uploader works. (It did in my testing)

Why was this MR needed?

Smaller JS payload.

What are the relevant issue numbers?

#14372 (closed)

Does this MR meet the acceptance criteria?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
File renamed with no changes. Show file contents
  • Can you add this $('body').attr('data-page').split(':').first() into common_utils and refactor the exact same usages ingl.utils.isInGroupsPage and gl.utils.isInProjectPage to use the new util method? It seems we are using a lot.

  • @connorshea This LGTM. Thank you for your effort on this and the other performance issues. I added a small refactor, can you please do it for sake of reusability? :100:

  • Reassigned to @connorshea

  • Connor Shea Added 1 commit:

    Added 1 commit:

    • 49d6e0a4 - Add a helper function for getting the page path from JS.
  • Connor Shea Added 2 commits:

    Added 2 commits:

    • a99e5cd8 - Split Cropper.js from the main JavaScript manifest.
    • 7b9b2ce3 - Add a helper function for getting the page path from JS.
  • Connor Shea Added 1 commit:

    Added 1 commit:

  • Reassigned to @fatihacet

  • Author Contributor

    @fatihacet tests are passing, ready to go

  • Fatih Acet Status changed to merged

    Status changed to merged

  • Fatih Acet mentioned in commit 57da2e87

    mentioned in commit 57da2e87

  • Tested in my local and it's working great. Thanks @connorshea :thumbsup:

    Screen_Shot_2016-07-08_at_22.03.57Screen_Shot_2016-07-08_at_22.02.39

  • Please register or sign in to reply
    Loading