Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Split Cropper.js from the main JavaScript manifest.
What does this MR do?
Splits Cropper.js from the main JavaScript file.
Are there points in the code the reviewer needs to double check?
That the avatar uploader works. (It did in my testing)
Why was this MR needed?
Smaller JS payload.
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
- Tests
-
All builds are passing
-
-
Conform by the style guides -
Branch has no merge conflicts with master
(if you do - rebase it please) -
Squashed related commits together
Merge request reports
Activity
Reassigned to @connorshea
Assigned @connorshea to properly handle moved/deleted files.
Reassigned to @fatihacet
- File renamed with no changes. Show file contents
@connorshea This LGTM. Thank you for your effort on this and the other performance issues. I added a small refactor, can you please do it for sake of reusability?
Reassigned to @connorshea
Added 1 commit:
- a87b229b - Fix preferences tests.
Reassigned to @fatihacet
@fatihacet tests are passing, ready to go
mentioned in commit 57da2e87
Tested in my local and it's working great. Thanks @connorshea
mentioned in merge request gitlab-com/www-gitlab-com!2497 (merged)
Mentioned in commit pfjason/gitlab-ce@57da2e87
Please register or sign in to reply