Ace ventura

What does this MR do?

Makes Ace only load when it's actually necessary. The only two places it seems to be used is for Snippets and the File (Blob) Editor.

Before minification or compression, this takes the application.js down from 2.2MB to 1.6MB, and also removes two inline scripts :D

Compressed/Minified: master: 317KB/1.1MB, ace-ventura: 220KB/771KB

Are there points in the code the reviewer needs to double check?

That this doesn't just completely break anything.

Why was this MR needed?

Ace is a big library, this allows us to only load it when necessary.

What are the relevant issue numbers?

#14372 (closed)

Does this MR meet the acceptance criteria?

• CHANGELOG entry added
• Tests
  • All builds are passing
• Conform by the style guides
• Branch has no merge conflicts with master (if you do - rebase it please)
• Squashed related commits together

Makes me wanna dance.

Added 1 commit:

• 8e75a3f0 - Probably important to include the files, huh?

Added 1 commit:

• c3a0a4d6 - Forgot one.

Added 73 commits:

• c3a0a4d6...e45d6043 - 70 commits from branch master
• 31673382 - Only load Ace on Snippets and file edit pages.
• 86092668 - Probably important to include the files, huh?
• 548fbe43 - Forgot one.

Added 1 commit:

• 1c7fde48 - D'oh

Added 1 commit:

• ed724b22 - Double D'oh.

Added 1 commit:

• b0edadbb - Fix tests?

Added 1 commit:

• 6eaa4791 - But really this time.

Added 1 commit:

• f9dbe6f2 - Probably important to include the files, huh?

@alfredo1 helped a ton with debugging this, he found that the version of PhantomJS we use is severely out-of-date (using a WebKit version from before 2012, at least). We should upgrade from 1.9.8 to 2.1.1 (latest). We'll have to build it ourselves, unfortunately.

https://github.com/teampoltergeist/poltergeist/issues/292

mentioned in issue #4216 (closed)

Added 454 commits:

• f9dbe6f2...10855e7f - 452 commits from branch master
• c752c937 - Only load Ace on Snippets and file edit pages.
• 7051941d - Probably important to include the files, huh?

Added 1 commit:

• 06bdce74 - Testing apt-get for installing phantom.

Added 1 commit:

• ffd1c0df - Testing apt-get for installing phantom.

Added 1 commit:

• d694f60d - Reverting.

Blocked by #4216 (closed)

@ayufan can we update PhantomJS? Pretty please

@jschatz1 Yes, can we do that after 8.10 release?

@ayufan I'd prefer to get this MR in this release, but if you're short on time then delaying it is perfectly fine.

Alternatively, do you know if anyone else would be able to do this for us?

mentioned in issue #19866 (closed)