WIP: Update grape gem (!4068) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.

Closed Achilleas Pipinellis requested to merge update-grape into master 8 years ago

From https://gitlab.com/gitlab-org/gitlab-ce/issues/14043#note_11654776, we are using an old version of grape which requires rack-mount, a gem that is deprecated and whose source code is no longer available. Relevant issue https://github.com/ruby-grape/grape/issues/1072.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18226

Activity

Achilleas Pipinellis @axil · 8 years ago

Author Developer
More info:

https://bugzilla.redhat.com/show_bug.cgi?id=1268593

https://lists.fedoraproject.org/pipermail/devel/2015-June/211769.html

https://groups.google.com/forum/?fromgroups#!topic/rack-devel/nNjuNIEZJis

That should be fun, expect all API tests to fail

Edited 8 years ago by Achilleas Pipinellis
Grzegorz Bizon @grzesiek · 8 years ago

Maintainer

Not bad, only 962 examples, 62 failures in spec:api :)
Connor Shea @connorshea · 8 years ago

Contributor

If it breaks fewer tests, we can always move to 0.15.1 and still get rid of that dependency :)
Achilleas Pipinellis mentioned in issue #18226 (closed) 8 years ago

mentioned in issue #18226 (closed)
Achilleas Pipinellis mentioned in issue #14043 (moved) 8 years ago

mentioned in issue #14043 (moved)
Connor Shea @connorshea · 8 years ago

Contributor

Newer MR is !4601 (merged)
Connor Shea Status changed to closed 8 years ago

Status changed to closed

Please register or sign in to reply