Skip to content

Show password fields even for users with linked accounts.

Cxx Stan requested to merge (removed):14379-fix-password-update into master

In merge https://gitlab.com/gitlab-org/gitlab-ce/commit/ba869ae50d0c43867f7d34a4f7e08520c1e4c7f1 for issue #13858 (closed), which was intended to be a UI/UX update, the password and password_confirmation fields were, I believe, accidentally aligned incorrectly under the check User#password_automatically_set? here.

Originally, this check just removed the current_password field, which wouldn't have been known by users where User#password_automatically_set? was set when creating their account with Github, et. al. After https://gitlab.com/gitlab-org/gitlab-ce/commit/ba869ae50d0c43867f7d34a4f7e08520c1e4c7f1 was merged, users that created their accounts using third party services are no longer able to update their password.

This update branch re-aligns the password edit haml file so that the password and password_confirmation fields are properly scoped to display regardless of User#password_automatically_set? and should fix issue #14379 (closed).

Merge request reports