Skip to content

Remove layout from charts and add them to their wrappers

Miguel Rincon requested to merge ce-27835-refactor-layout-charts-panel into master

What does this MR do?

Remove col-* classes in our monitor chart components, so they can be rendered independently in different situations.

The layout classes are added to the wrappers: embed and panel_type.

It should only be a refactor with no change in functionality, expect for a quick fix for https://gitlab.com/gitlab-org/gitlab-ee/issues/14783

Technical background

In order to move and resize panels in dashboard col-* classes must be owned by the dashboard itself. Required for https://gitlab.com/gitlab-org/gitlab-ee/issues/27835

Screenshots

desktop mobile
2019-09-12_13.07.21 2019-09-12_13.12.43

Does this MR meet the acceptance criteria?

Conformity

Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/27835

Fix for https://gitlab.com/gitlab-org/gitlab-ee/issues/14783

Edited by 🤖 GitLab Bot 🤖

Merge request reports