Skip to content

Refine the review-app custom variables

Kyle Wiebers requested to merge review-app-optimizations into master

Refactor the config variables that are passed into the Review App via helm into a base-config.yaml set of values.

  • Disable certmanager, usagePing, mailroom, prometheus, redis-ha.
  • Set resource requests and limits (where applicable) for:
    • gitaly (increased both from upstream chart due to timeout issues)
    • gitlab-exporter
    • migrations
    • sidekiq
    • task-runner
    • unicorn
    • workhorse
    • gitlab-runner
    • minio
    • nginx-ingress-controller
    • nginx-ingress-default-backend
    • postgres-metrics
    • postgres
    • redis-metrics
    • redis
    • registry
  • Set minimum replicas (or explicit replica counts)
    • nginx-ingress-controller
    • nginx-ingress-default-backend
    • registry

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Relates to https://gitlab.com/gitlab-org/quality/team-tasks/issues/212

Edited by Kyle Wiebers

Merge request reports