Skip to content

WIP: Pass `rules:` downstream.

Kamil Trzciński requested to merge fix-rules-not-working into master

What does this MR do?

This makes rules: to work, as today it is not working.

We seem that we miss the e2e tests validating that this feature does in fact gets considered when executing via CreatePipelineService.

This partially fixes that.

Related: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29011.

Related to: https://gitlab.com/gitlab-org/gitlab-ce/issues/60085

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports