Expose `name` and `merge_request_event_type` in serialized json and predefined variables

What does this MR do?

This MR exposes name and merge_request_event_type in serialized json for pipeline entity. This is only BE change and you can find FE change at https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14664.

Here is the conversion table.

Pipeline type	pipeline.name	pipeline.merge_request_event_type	Condition
Pipelines for merge train	Merge train pipeline	'merge_train'	N/A
Pipelines for merged results	Merged result pipeline	'merged_result'	pipeline.flags.merge_request_pipeline === true (To be removed in https://gitlab.com/gitlab-org/gitlab-ee/issues/13991)
Pipelines for merge requests (detached)	Detached merge request pipeline	'detached'	pipeline.flags.detached_merge_request_pipeline === true (To be removed in https://gitlab.com/gitlab-org/gitlab-ee/issues/13991)
Branch pipelines	Pipeline	undefined	pipeline.ref.branch === true
Tag pipelines	Pipeline	undefined	pipeline.ref.tag === true

This MR also exposes the pipeline.merge_request_event_type as CI_MERGE_REQUEST_EVENT_TYPE predefined variable for a customer request.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

• [-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. => This is going to be added in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14664
• [-] Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

	1 Warning
	The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	Steve Abrams (@sabrams)	Jan Provaznik (@jprovaznik)

Generated by Danger

added 1 commit

• 7948023b - Add pipeline.type key to PipelineEntity

Compare with previous version

changed milestone to %12.3

added Deliverable devopsrelease [DEPRECATED] labels

added typefeature label

changed the description

@splattael This MR was decoupled from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14664 for backend only changes. The points you raised in the previous MR have already been addressed. Would you mind reviewing this MR as backend reviewer? Thanks!

assigned to @splattael

changed title from {-Add pipeline.type key to PipelineEntity-} to {+Expose pipeline.type and pipeline.details.type_label in serialized json+}

added backstage [DEPRECATED] label

changed the description

assigned to @dosuken123 and unassigned @splattael

changed the description

added 13 commits

• 7948023b...e8bcabb4 - 12 commits from branch master
• c0d7562d - Add pipeline.type key to PipelineEntity

Compare with previous version

assigned to @ayufan and unassigned @dosuken123

changed title from Expose pipeline.type {-and pipeline.details.type_label in serialized json-} to Expose pipeline.type in serialized json and predefined variables

@dosuken123

I like this. And I agree that this is needed. I wonder about naming and split. I would maybe propose to have #entity and what is described in one comment instead of bundling everything into one #type. I would likely not use #type as it overlays with STI, even if it is not a problem today, I'm unsure if it will not be later.

assigned to @dosuken123 and unassigned @ayufan

@splattael @ayufan Thank you for reviewing!

added 228 commits

• c0d7562d...153f25af - 227 commits from branch master
• 7650d7a5 - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• 55152da0 - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• f8d2eb40 - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• c4ef467c - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• ce74d89c - Add pipeline.type key to PipelineEntity

Compare with previous version

changed title from Expose {-pipeline.-}type in serialized json and predefined variables to Expose {+name and merge_request_event_+}type in serialized json and predefined variables

changed the description

added 1 commit

• bee8cc43 - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• 4eaab3c5 - Add pipeline.type key to PipelineEntity

Compare with previous version

mentioned in issue #66806 (moved)

@ayufan I've addressed all comments. Back to you.

assigned to @ayufan and unassigned @dosuken123

resolved all threads

approved this merge request

assigned to @dosuken123 and unassigned @ayufan

@dosuken123 LGTM just one comment.

mentioned in merge request !31722 (merged)

added 223 commits

• 4eaab3c5...991143eb - 222 commits from branch master
• 77978d51 - Add pipeline.type key to PipelineEntity

Compare with previous version

added 1 commit

• 8c21610c - Add pipeline.type key to PipelineEntity

Compare with previous version

resolved all threads

resolved all threads

@ayufan Back to you.

assigned to @ayufan and unassigned @dosuken123

Locally confirmed it's functional.

resolved all threads

merged

mentioned in commit 6b7fe67a

mentioned in issue gitlab-com/www-gitlab-com#3781 (closed)

mentioned in issue gitlab#37482 (closed)