Skip to content

Fix "ERR value is not an integer or out of range" errors

Stan Hu requested to merge sh-revert-redis-cache-store into master

ActiveSupport::Cache::RedisCacheStore is not compatible with the version of Rack Attack we are using (v4.4.1) per https://github.com/kickstarter/rack-attack/issues/281. Users that had rate limits enabled might see Redis::CommandError: ERR value is not an integer or out of range because the raw parameter wasn't passed along properly. As a result, the Rack Attack entry would be stored as an ActiveSupport::Cache::Entry instead of a raw string holding an integer value.

Let's partially revert the change in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30966 to use the original cache store until we can update to Rack Attack v5.2.3 that has support for ActiveSupport::Cache::RedisCacheStore via https://github.com/kickstarter/rack-attack/pull/350.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66449

Edited by Stan Hu

Merge request reports