Skip to content

Replace inline scripts in links to prevent default

Heinrich Lee Yu requested to merge add-js-prevent-default-on-click into master

What does this MR do?

Replaces inline javascript:void(0) to use unobtrusive JS.

This introduces a new js-prevent-default-on-click that does a preventDefault on click.

This would prevent errors when we enable CSP by default in https://gitlab.com/gitlab-org/gitlab-ce/issues/65675

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports