Skip to content

Prefer ActiveModel's attributes over Virtus

Peter Leitzen requested to merge pl-remove-virtus into master

What does this MR do?

At GitLab we use Virtus sporadically.

The Piotr Solnica announced to discontinue this project (Twitter).

There are several alternatives available e.g. dry-types and we might end up using it if we decide to use some other gems from the dry-rb ecosystem as discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/56767.

In the meantime, ActiveModel borrowed its "type system" from ActiveRecord so we can define typed attributes via attribute :name, TYPE 🎉

Let's utilize this 💪

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports