Moves Protected paths throttling from Omnibus to GitLab Rails
-
Review changes -
-
Download -
Patches
-
Plain diff
Closed
Mayra Cabrera requested to merge mc-moves-protected-path-throttle-to-gitlab-rails into master
What does this MR do?
Moves protected paths to GitLab-Rails:
- Adds 4 columns to
application_settings
- 3 to mimic the configuration of existing throttles
- 1 to store the protected paths on database
- Set default protected paths (taken from Omnibus)
- Add new section on admin panel to personalize protected paths configuration
- This new throttle is active by default.
- Includes additional protected paths throttles
- Rack Attack file was renamed to 'rack_attack_gitlab_rails'.rb, otherwise the Omnibus file will overwrite this file.
- If the settings are enabled, they will take precedence over the Omnibus settings
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278
Documentation MR - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32773
Screenshots
Protected paths configuration |
---|
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32773 -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16463
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64278
To do - backend
-
Move Protected Paths to config/gitlab.yml
-
Handle the throttle on RackAttackGlobal
-
Add specs -
Log error on auth.log
-
Add new application_settings to UI -
Refactor -
Configure protected paths on UI -
EE port - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/16463
Edited by Mayra Cabrera
Merge request reports
Compare and
Show latest version
- version 31620a8520
- version 30aa6efbd6
- version 2902db01fc
- version 28ba382074
- version 271dbaba96
- version 26ede05de9
- version 256c82be68
- version 24b4d51f13
- version 2390e5af2c
- version 2237b5aa8c
- version 21669c00de
- version 20eb8f7897
- version 19ec461027
- version 1887ed144a
- version 17772871d9
- version 16750caa5e
- version 15eddff87f
- version 1424897e91
- version 13dc7ac58f
- version 1218e19738
- version 11fb29949b
- version 108983a679
- version 952ce7aa9
- version 8a731ba66
- version 793b6dc32
- version 622e2c6c7
- version 5d18e0eea
- version 4d4ec8bcc
- version 39ed1eb66
- version 2fffbf16a
- version 16ed85a6a
- master (base)
- latest versioned622fcc1 commit,
- version 31620a85201 commit,
- version 30aa6efbd61 commit,
- version 2902db01fc1 commit,
- version 28ba3820741 commit,
- version 271dbaba961 commit,
- version 26ede05de91 commit,
- version 256c82be681 commit,
- version 24b4d51f131 commit,
- version 2390e5af2c1 commit,
- version 2237b5aa8c1 commit,
- version 21669c00de1 commit,
- version 20eb8f78971 commit,
- version 19ec4610271 commit,
- version 1887ed144a1 commit,
- version 17772871d91 commit,
- version 16750caa5e1 commit,
- version 15eddff87f1 commit,
- version 1424897e911 commit,
- version 13dc7ac58f1 commit,
- version 1218e197381 commit,
- version 11fb29949b1 commit,
- version 108983a6791 commit,
- version 952ce7aa91 commit,
- version 8a731ba661 commit,
- version 793b6dc321 commit,
- version 622e2c6c71 commit,
- version 5d18e0eea1 commit,
- version 4d4ec8bcc1 commit,
- version 39ed1eb661 commit,
- version 2fffbf16a1 commit,
- version 16ed85a6a1 commit,
Compare changes
- Side-by-side
- Inline
Files
365Loading