Skip to content

Optimise import performance

Kamil Trzciński requested to merge optimise-import-performance into master

What does this MR do?

EE version: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14794

  • Fix O(n) complexity of append_or_update_attribute, we append objects to an array and re-save project
  • Remove the usage of keys.include? as it performs O(n) search, instead use .has_key?
  • Remove the usage of .keys.first as it performs a copy of all keys, instead use .first.first

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64924

Does this MR meet the acceptance criteria?

Conformity

Edited by 🤖 GitLab Bot 🤖

Merge request reports