Skip to content

Create virtual host configuration API for GitLab Pages

Krasimir Angelov requested to merge 61927-pages-virtual-hosts-api into master

What does this MR do?

This MR creates internal API that GitLab Pages can use to request virtual host configuration for given host.

There are two major parts:

  • Authentication between the Pages and the Rails app (using JWT similar to how GitLab Workhorse and the Rails app talk)
  • Internal API endpoint GET /pages?host=... that returns the virtual host configuration for this domain

Port to EE MR - https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14821.

Omnibus MR - omnibus-gitlab!3444 (closed).

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #61927 (moved).

Edited by Krasimir Angelov

Merge request reports