Skip to content
Patrick Bajao requested to merge 10646-create-drafts-with-commit-id-ce into master

What does this MR do?

CE port of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14520

Includes:

  • migration to add commit_id to draft_notes table
  • diff_refs_match_commit validation moved to DiffPositionableNote concern so it can be re-used.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

https://gitlab.com/gitlab-org/gitlab-ee/issues/10646

Edited by Patrick Bajao

Merge request reports