Include the GitLab version in the cache key for Gitlab::JsonCache
What does this MR do?
Ensure Gitlab::JsonCache
includes the GitLab version in the cache key.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issues
Merge request reports
Activity
changed milestone to %12.1
added devopssystems groupgeo + 1 deleted label
1 Warning 94d9e335: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Luke Duncalfe ( @.luke
)Grzegorz Bizon ( @grzesiek
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖@stanhu Can you review, please?
added Pick into auto-deploy label
assigned to @stanhu and unassigned @dbalexandre
@dbalexandre Looks good to me! I think we can move this to ~"Pick into 12.0", since tomorrow's release day.
added 1 deleted label and removed Pick into auto-deploy label
mentioned in commit c6f54ab1
added Pick into auto-deploy label
removed Pick into auto-deploy label
mentioned in issue #63513 (closed)
Geo EE specs started failing once it was auto-merged into EE - fixed in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14327 (presuming we want this enabled for Geo)
~~Adding Pick into auto-deploy since https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14327#note_184553041 was picked.~~ Nvm, the auto-deploy branch already includes these changes.
Edited by Douglas Barbosa Alexandreadded Pick into auto-deploy label
@dbalexandre This merge request could not automatically be picked into
12-1-auto-deploy-0011201
for12.1.0
and will need manual intervention. Please create a new MR targeting the source branch of12-1-auto-deploy-0011201
, and assign to release managers.@dbalexandre This merge request could not automatically be picked into
12-1-auto-deploy-0011201
for12.1.0
and will need manual intervention. Please create a new MR targeting the source branch of12-1-auto-deploy-0011201
, and assign to release managers.removed Pick into auto-deploy label
added typebug label
mentioned in issue gitlab-org/release/tasks#827 (closed)
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30045, will merge into
12-0-stable
ready for12.0.2
.mentioned in commit f24e8f41
mentioned in merge request !30045 (merged)
mentioned in issue gitlab-org/release/tasks#831 (closed)
mentioned in issue gitlab-org/release/tasks#834 (closed)