Skip to content
Snippets Groups Projects

Include the GitLab version in the cache key for Gitlab::JsonCache

Merged Include the GitLab version in the cache key for Gitlab::JsonCache
63513-ensure-gitlab-jsoncache-includes-the-gitlab-version-in-the-cache-key into master
Merged Douglas Barbosa Alexandre requested to merge 63513-ensure-gitlab-jsoncache-includes-the-gitlab-version-in-the-cache-key into master

What does this MR do?

Ensure Gitlab::JsonCache includes the GitLab version in the cache key.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related issues

#63513 (closed)

Edited by Douglas Barbosa Alexandre

Merge request reports

Pipeline #67434119 passed with warnings

Stage: build
Stage: prepare
Stage: test
Stage: review
Stage: qa
Stage: post-test
Stage: post-cleanup

Pipeline passed with warnings for 1b7e7dde on 63513-ensure-gitlab-jsoncache-includes-the-gitlab-version-in-the-cache-key

Test coverage 75.16% (20.58%) from 2 jobs
Approved by
Sean McGivern

Merged by Stan HuStan Hu 5 years ago (Jun 21, 2019 8:39pm UTC)

Pipeline #67468246 passed with warnings

Stage: build
Stage: prepare
Stage: test
Stage: review
Stage: post-test
Stage: pages
Stage: post-cleanup
Stage: deploy

Pipeline passed with warnings for c6f54ab1 on master

Test coverage 75.17% (20.58%) from 2 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply