Skip to content

Build correct basenames for title search results

Markus Koller requested to merge search-blob-basenames into master

What does this MR do?

This was previously fixed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27400, but the problematic code was still present in FoundBlob, and the corresponding spec didn't actually use a child wiki page to properly verify the fix.

Reference: https://gitlab.com/gitlab-org/gitlab-ce/issues/60910

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports