Skip to content

Rearrange discussion resolve buttons

Samantha Ming requested to merge 58689-regroup-jump-button-in-discussion into master

What does this MR do?

Update discussion resolve/unresolve button arrangements.

Test Case

  1. Navigate to Merge Requests > [select a MR] > Changes
  2. Hover on any line of the code to trigger the speech bubble icon and click on it.
  3. Comment box will appear. Leave a random comment and click the "Comment" button to submit
  4. Switch to the Discussion tab (Make sure you are not on the changes tab)
  • Unresolved discussion looks like this:

_

  • When there are 2 or more unresolved discussion, Resolved discussion look like this:

image

  • When there is 1 or less unresolved discussion, Resolved discussion look like this:

image

  • Mobile view looks something like this:

_

Tested on:

  • IE11
  • Edge
  • Safari
  • Firefox
  • Chrome

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #58689 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports