Skip to content

Use Rugged if we detect storage is NFS and we can access the disk

John Cai requested to merge jc-detect-nfs-for-rugged into master

What does this MR do?

Part of: https://gitlab.com/gitlab-org/gitlab-ce/issues/60931

Detects if storage is on NFS, and if we can reach the storage path, and if the feature flag is turned on. If these conditions are true, then we can use the rugged implementation.

I think the goal is to get rid of the feature flag all together.

related: gitaly!1289 (merged)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by John Cai

Merge request reports