Skip to content

Fix user nil exception in PipelineScheduleService

Shinya Maeda requested to merge master-ce into master

What does this MR do?

There seem an edge case that owner_id of ci_pipeline_schedules rows has NULL values.

gitlabhq_production=> SELECT count(id) FROM ci_pipeline_schedules WHERE owner_id IS NULL;
 count 
-------
   219
(1 row)

Because of this, PipelineScheduleWorker aborts the operation in the halfway, which results in inconsistent schedules gitlab-com/gl-infra/production#805 (comment 179904391).

Close https://gitlab.com/gitlab-org/gitlab-ce/issues/63086

Close gitlab-com/gl-infra/production#805 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports